fix: use atomic writes for FileCache to prevent race conditions #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Donghyeon Ko <[email protected]>
Gosorasora
force-pushed
the
fix/atomic-cache-write
branch
from
45ef6d8 to
d54c997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes race condition when multiple processes access the same cache file concurrently.
Related issue: wasmCloud/wasmCloud#4842
Problem
When two processes write to the same cache file simultaneously, one may read
an incomplete file, causing "unexpected end-of-file" errors.
Solution
Use atomic writes by writing to a temporary file first, then renaming it to
the final path. The
renameoperation is atomic on most filesystems.Changes
put_datainFileCacheto write to temp file first